FPGA Central - World's 1st FPGA / CPLD Portal

FPGA Central

World's 1st FPGA Portal

 

Go Back   FPGA Groups > NewsGroup > FPGA

FPGA comp.arch.fpga newsgroup (usenet)

Reply
 
LinkBack Thread Tools Display Modes
  #1 (permalink)  
Old 04-19-2006, 07:55 PM
Sylvain Munaut
Guest
 
Posts: n/a
Default EDK : FSL macros defined by Xilinx are wrong

Hi everyone,

I hope someone @Xilinx will read this.

In the new EDK 8.1 the FSL access macros have changed
name. And they also introduced _interruptible versions.
Theses are defined in
${EDK_HOME}/sw/lib/bsp/standalone_v1_00_a/src/microblaze/mb_interface.h

The definitions for getfsl_interruptible and
cgetfsl_interruptible are correct. But the ones for
putfsl_interruptible and cputfsl_interruptible are
incorrect. For example putfsl_interruptible is :

#define putfsl_interruptible(val, id) \
asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
"addic\tr18,r0,0\n\t" \
"bnei\tr18,1b\n" \
: "=d" (val) :: "r18")

and it should be :

#define putfsl_interruptible(val, id) \
asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
"addic\tr18,r0,0\n\t" \
"bnei\tr18,1b\n" \
:: "d" (val) : "r18")

Obviously val is a input in the case of a 'put' and not
an output.


Another related question : In my code, when a replace all
non _interruptible versions by their _interruptible counter
parts, it doesn't behave as excpected anymore ...
Does theses version require some hw support ?



Sylvain



PS: I know I should submit a webcase but when I try to login
I just get "Server Error" ... and so I obviously can't even
submit a webcase about my problem of being unable to log in
into the webcase ...
Reply With Quote
  #2 (permalink)  
Old 04-21-2006, 09:18 PM
Sylvain Munaut
Guest
 
Posts: n/a
Default Re: EDK : FSL macros defined by Xilinx are wrong

Can anyone @Xilinx can confirm they read this and will take
care of it ?


Sylvain Munaut wrote:
> Hi everyone,
>
> I hope someone @Xilinx will read this.
>
> In the new EDK 8.1 the FSL access macros have changed
> name. And they also introduced _interruptible versions.
> Theses are defined in
> ${EDK_HOME}/sw/lib/bsp/standalone_v1_00_a/src/microblaze/mb_interface.h
>
> The definitions for getfsl_interruptible and
> cgetfsl_interruptible are correct. But the ones for
> putfsl_interruptible and cputfsl_interruptible are
> incorrect. For example putfsl_interruptible is :
>
> #define putfsl_interruptible(val, id) \
> asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
> "addic\tr18,r0,0\n\t" \
> "bnei\tr18,1b\n" \
> : "=d" (val) :: "r18")
>
> and it should be :
>
> #define putfsl_interruptible(val, id) \
> asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
> "addic\tr18,r0,0\n\t" \
> "bnei\tr18,1b\n" \
> :: "d" (val) : "r18")
>
> Obviously val is a input in the case of a 'put' and not
> an output.
>
>
> Another related question : In my code, when a replace all
> non _interruptible versions by their _interruptible counter
> parts, it doesn't behave as excpected anymore ...
> Does theses version require some hw support ?
>
>
>
> Sylvain
>
>
>
> PS: I know I should submit a webcase but when I try to login
> I just get "Server Error" ... and so I obviously can't even
> submit a webcase about my problem of being unable to log in
> into the webcase ...

Reply With Quote
  #3 (permalink)  
Old 04-21-2006, 09:56 PM
Austin Lesea
Guest
 
Posts: n/a
Default Re: EDK : FSL macros defined by Xilinx are wrong

Sylvain,

I got it.

I will find out what happened, and report back.

Thanks,

Austin

Sylvain Munaut wrote:

> Can anyone @Xilinx can confirm they read this and will take
> care of it ?
>
>
> Sylvain Munaut wrote:
>
>> Hi everyone,
>>
>> I hope someone @Xilinx will read this.
>>
>> In the new EDK 8.1 the FSL access macros have changed
>> name. And they also introduced _interruptible versions.
>> Theses are defined in
>> ${EDK_HOME}/sw/lib/bsp/standalone_v1_00_a/src/microblaze/mb_interface.h
>>
>> The definitions for getfsl_interruptible and
>> cgetfsl_interruptible are correct. But the ones for
>> putfsl_interruptible and cputfsl_interruptible are
>> incorrect. For example putfsl_interruptible is :
>>
>> #define putfsl_interruptible(val, id) \
>> asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
>> "addic\tr18,r0,0\n\t" \
>> "bnei\tr18,1b\n" \
>> : "=d" (val) :: "r18")
>>
>> and it should be :
>>
>> #define putfsl_interruptible(val, id) \
>> asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
>> "addic\tr18,r0,0\n\t" \
>> "bnei\tr18,1b\n" \
>> :: "d" (val) : "r18")
>>
>> Obviously val is a input in the case of a 'put' and not
>> an output.
>>
>>
>> Another related question : In my code, when a replace all
>> non _interruptible versions by their _interruptible counter
>> parts, it doesn't behave as excpected anymore ...
>> Does theses version require some hw support ?
>>
>>
>>
>> Sylvain
>>
>>
>>
>> PS: I know I should submit a webcase but when I try to login
>> I just get "Server Error" ... and so I obviously can't even
>> submit a webcase about my problem of being unable to log in
>> into the webcase ...

Reply With Quote
  #4 (permalink)  
Old 04-21-2006, 11:49 PM
Austin Lesea
Guest
 
Posts: n/a
Default Re: EDK : FSL macros defined by Xilinx are wrong

All,

Here is the answer:

"Hi,

Yes this is a bug. This issue is being fixed for the next EDK release
(8.2i). Also, your patches seem correct."

Austin

Austin Lesea wrote:

> Sylvain,
>
> I got it.
>
> I will find out what happened, and report back.
>
> Thanks,
>
> Austin
>
> Sylvain Munaut wrote:
>
>> Can anyone @Xilinx can confirm they read this and will take
>> care of it ?
>>
>>
>> Sylvain Munaut wrote:
>>
>>> Hi everyone,
>>>
>>> I hope someone @Xilinx will read this.
>>>
>>> In the new EDK 8.1 the FSL access macros have changed
>>> name. And they also introduced _interruptible versions.
>>> Theses are defined in
>>> ${EDK_HOME}/sw/lib/bsp/standalone_v1_00_a/src/microblaze/mb_interface.h
>>>
>>> The definitions for getfsl_interruptible and
>>> cgetfsl_interruptible are correct. But the ones for
>>> putfsl_interruptible and cputfsl_interruptible are
>>> incorrect. For example putfsl_interruptible is :
>>>
>>> #define putfsl_interruptible(val, id) \
>>> asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
>>> "addic\tr18,r0,0\n\t" \
>>> "bnei\tr18,1b\n" \
>>> : "=d" (val) :: "r18")
>>>
>>> and it should be :
>>>
>>> #define putfsl_interruptible(val, id) \
>>> asm volatile ("\n1:\n\tnput\t%0,rfsl" #id "\n\t" \
>>> "addic\tr18,r0,0\n\t" \
>>> "bnei\tr18,1b\n" \
>>> :: "d" (val) : "r18")
>>>
>>> Obviously val is a input in the case of a 'put' and not
>>> an output.
>>>
>>>
>>> Another related question : In my code, when a replace all
>>> non _interruptible versions by their _interruptible counter
>>> parts, it doesn't behave as excpected anymore ...
>>> Does theses version require some hw support ?
>>>
>>>
>>>
>>> Sylvain
>>>
>>>
>>>
>>> PS: I know I should submit a webcase but when I try to login
>>> I just get "Server Error" ... and so I obviously can't even
>>> submit a webcase about my problem of being unable to log in
>>> into the webcase ...

Reply With Quote
  #5 (permalink)  
Old 04-22-2006, 07:33 AM
Sylvain Munaut
Guest
 
Posts: n/a
Default Re: EDK : FSL macros defined by Xilinx are wrong

Austin Lesea wrote:
> All,
>
> Here is the answer:
>
> "Hi,
>
> Yes this is a bug. This issue is being fixed for the next EDK release
> (8.2i). Also, your patches seem correct."
>
> Austin
>


GReat, thanks for the followup.


Sylvain
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Xilinx Adder Subtracter Core (What's Wrong With Xilinx People??!) [email protected] FPGA 27 12-06-2005 11:06 AM
Problem in using Hard Macros in Xilinx ISE 7.1 Love Singhal FPGA 0 08-22-2005 10:12 PM
Newbie Question on Xilinx Macros and Pads Durward FPGA 0 03-07-2004 05:33 AM


All times are GMT +1. The time now is 05:19 AM.


Powered by vBulletin® Version 3.8.0
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0
Copyright 2008 @ FPGA Central. All rights reserved